pingcap/tidb

metrics for tikv client should distinguish TiKV and TiFlash

Open

#16,107 建立於 2020年4月7日

在 GitHub 查看
 (1 留言) (0 反應) (1 負責人)Go (40,090 star) (6,186 fork)batch import
component/coprocessorcomponent/metricsfeature/acceptedhelp wantedtype/feature-request

描述

Feature Request

Is your feature request related to a problem? Please describe:

For now, the metrics of the tikv client statistics some infos like "backoff seconds", "cop_duration_seconds" and etc. are all named tikvclient. That's not friendly with TiFlash. We'd better distinguish them.

labels need to expand:

  • "txn_cmd_duration_seconds"
  • "backoff_seconds"
  • "request_seconds"
  • "cop_duration_seconds"
  • "region_err_total"
  • "txn_regions_num"
  • "pending_batch_requests"
  • "batch_wait_duration"
  • "batch_client_unavailable_seconds"

貢獻者指南

技術棧
goprometheus
領域
observabilitybackend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
GoPrometheus metrics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
35
研究方向
The issue requests expanding labels for multiple metrics in the tikv client to distinguish TiKV and TiFlash. Look at the existing metric definitions in the Go codebase (likely under a metrics or client package). Each metric may need a 'store type' label. Since the issue has an assignee, check if any related work is in progress. The changes are iterative and localized.
metrics for tikv client should distinguish TiKV and TiFlash · pingcap/tidb#16107 | Good First Issue