pingcap/tidb

Move the check for `_tidb_rowid` from executor to planner

Open

#14,221 建立於 2019年12月25日

在 GitHub 查看
 (0 留言) (0 反應) (1 負責人)Go (40,090 star) (6,186 fork)batch import
help wantedtype/enhancement

描述

Feature Request

Describe the feature you'd like:

Currently we check the _tidb_rowid in executor: https://github.com/pingcap/tidb/blob/57ecfb9b466392853200e9ffebcdd6ebf631ab91/executor/update.go#L284-L293 https://github.com/pingcap/tidb/blob/57ecfb9b466392853200e9ffebcdd6ebf631ab91/executor/insert_common.go#L135-L142

It's better to check this in planer.

貢獻者指南

技術棧
go
領域
backenddatabase
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
GoTiDB codebase knowledge
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
The issue requests moving the check for ` tidb rowid` from executor files (executor/update.go and executor/insert common.go) to the planner. The maintainer has assigned someone, indicating work may be in progress. To proceed, first examine the current logic in the executor files linked in the issue, then understand how similar checks are performed in the planner package. The goal is to relocate the validation without changing behavior. Check for any existing planner tests that might need updating.