pingcap/tidb

Support SO_REUSEPORT

Open

#13,808 建立於 2019年11月28日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Go (40,090 star) (6,186 fork)batch import
component/serverfeature/acceptedhelp wantedpriority/P1type/feature-request

描述

Feature Request

Is your feature request related to a problem? Please describe:

Describe the feature you'd like:

Support SO_REUSEPORT for TiDB

After Linux version 3.9, TCP and UDP support for the SO_REUSEPORT socket option; that support was implemented in a series of patches by Tom Herbert. The new socket option allows multiple sockets on the same host to bind to the same port, and is intended to improve the performance of multithreaded network server applications running on top of multicore systems.

Benefits:

  1. For multicore systems, multiple instances of tidb-server can listen to a same port providing service. Here's a picture to demonstrate how it's working. Note that ports of the three instance is the same (4000), but the status port is not the same (for monitoring each instance).
  2. Support graceful upgrading if we have a supervisor process to manage all tidb-server instance in one machine.

Describe alternatives you've considered:

  1. tidb-ansible may need to be modified because it's waiting for the port of tidb-server listening to make sure the process is started. After supporting SO_REUSEPORT, each tidb-server on a same machine may be listening to a same port.

Teachability, Documentation, Adoption, Migration Strategy:

貢獻者指南

技術棧
go
領域
backend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
over 1 week
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Go programmingTCP/IP networkingLinux socket options
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
Start by examining the TiDB server's main entry point (e.g., tidb server/main.go) and the listener setup in server/server.go. Research how to enable SO REUSEPORT on a TCP listener in Go using net.ListenConfig and Control function. Also check any existing socket options set in the codebase. Review the linked docs.google.com diagram for deployment context. Consider testing with multiple instances on the same port and updating deployment tools like tiup or ansible if necessary.