pingcap/tidb

Imporve the performance of writing chunks to connection.

Open

#13,052 建立於 2019年10月31日

在 GitHub 查看
 (1 留言) (1 反應) (0 負責人)Go (40,090 star) (6,186 fork)batch import
component/serverhelp wantedtype/enhancementtype/performance

描述

Feature Request

Is your feature request related to a problem? Please describe:

In https://github.com/pingcap/tidb/blob/7bfa896/server/conn.go#L1269, we have a chunk to write to connection, but we dump a chunk to mysql protocol row by row.

Describe the feature you'd like:

Now we can vectorize dumpBinaryRow and dumpTextRow by converting a chunk to network buffer column by column.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

貢獻者指南

技術棧
gosql
領域
backenddatabaseperformance
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
3-5 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
GoTiDB internalsMySQL protocolperformance optimization
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
The issue asks to vectorize `dumpBinaryRow` and `dumpTextRow` in `server/conn.go` at line 1269. Currently, the chunk is written row by row. The solution involves converting a chunk to network buffer column by column. To implement this, first understand the current row by row dumping logic and the Chunk structure in TiDB. Then design a columnar conversion that writes all rows for one column before moving to the next. Benchmarks should be created to measure performance improvement. No existing PRs or assignees; the issue is from 2019, so re evaluate with current codebase and discuss with maintainers.