pingcap/tidb

Incompatible issues about scalar functions(help wanted)

Open

#11,223 建立於 2019年7月12日

在 GitHub 查看
 (3 留言) (6 反應) (0 負責人)Go (40,090 star) (6,186 fork)batch import
challenge-programcomponent/expressionhelp wantedsig/executiontype/compatibility

描述

Description

I've used https://github.com/MariaDB/randgen/blob/ed5de7968d1cc00c872588fcfe1074b9237e38d1/conf/mariadb/functions.yy to test scalar functions in TiDB, these are issues we got currently. You can find all these definitions of these functions on https://dev.mysql.com/doc/refman/5.7/en/func-op-summary-ref.html.

  • #11212: Different results of Function :=(Assign a value)
  • #11211: Mod(%) operator meets inconsistent 0 results.
  • #11210: ErrBadField occurs when using Function DEFAULT with ORDER BY clause
  • #11208: Results of function SUM is different from MySQL.
  • #11206: Results of function FORMAT is different from MySQL.
  • #11205: Result of function ROUND is different from MySQL
  • #11203: Result of function QUARTER/DATE_FORMAT is different from MySQL.
  • #11200: Result of function BIT_AND is different from MySQL.
  • #11199: Result of function OR is not correct.
  • #11198: Result of function BIT_OR is different from mysql.
  • #11197: Function arguments in error message should represent as a column name if possible.
  • #11195: Function OCTET_LENGTH is not implemented but the documentation says yes.
  • #11193: Should check the range of the DECIMAL's arguments
  • #11190: The result of Function COALESCE is different from MySQL.
  • #11188: Function NOT/IF returns incorrect result with decimal argument
  • #11181: Function name is missing in error message.
  • #11180: Different result from MySQL using DIV with decimal type.
  • #11179: Different result from Mysql when casting a type conversation from a long string to an integer.
  • #11178: Function DAY/DAYOFMONTH should do type conversation
  • #11177: Invalid results using BETWEEN...AND... with type conversation.
  • #11175: Function SUBTIME should return NULL with a warning if its argument is an invalid time value.
  • #11174: Function INSERT should be NULL if any argument is NULL
  • #11171: SELECT 0 LIKE 'a string' should not be true.
  • #11163: The result of function COMPRESS is different from MySQL
  • #11161: CONVERT_TZ should return NULL if its arguments are invalid.
  • #11147: Function information in error message should take along with database name
  • #11146: Can't be negative the value of NAME_CONST.
  • #11145: Column information in error message is missing.
  • #11140: Column information in error message should take along with database name
  • #9871: CAST float is not compatible with MySQL
  • #11304: The warning message of incorrect datetime is corrupt. @ono-yoko https://github.com/pingcap/tidb/pull/11445
  • #11256 :Result of DATE_ADD function is different from mysql.(YEAR overflow) @AndrewDi https://github.com/pingcap/tidb/pull/11472
  • #11309 :Wrong result of Dateadd() when it working on a Decimal(or float,double) column @AndrewDi https://github.com/pingcap/tidb/pull/11479
  • #11319 :Result of DATE_ADD function is different from mysql.(Second) @yangwenmai https://github.com/pingcap/tidb/pull/11312
  • #11645 :Result of DATE_ADD function is different from mysql.(string INTERVAL)
  • #11329 :DATETIME's behaviour is different from mysql
  • #12786: Diffrent behaviour from MySQl when cast string to time

SIG slack channel

#sig-exec

Score

  • 300

Mentor

  • @XuHuaiyu

貢獻者指南

技術棧
gosql
領域
database
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
5
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
over 1 week
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Go programmingSQL knowledgeTiDB codebaseMySQL compatibility
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
15
研究方向
This tracking issue lists many scalar function incompatibilities between TiDB and MySQL. The remaining open issues (#11200, #11193, #11181) are good starting points. To fix, study the MySQL documentation for the function, then locate the TiDB implementation in the `expression` package (e.g., `expression/builtin math.go`). Write test cases comparing TiDB output to MySQL. The mentor is @XuHuaiyu; consider reaching out in #sig exec Slack channel. Refer to the `conf/mariadb/functions.yy` file used for testing.
Incompatible issues about scalar functions(help wanted) · pingcap/tidb#11223 | Good First Issue