pingcap/tidb

Error should be thrown when there's ASC/DESC with GROUP BY clause

Open

#10,522 建立於 2019年5月17日

在 GitHub 查看
 (8 留言) (0 反應) (1 負責人)Go (40,090 star) (6,186 fork)batch import
help wantedpriority/P4sig/plannertype/feature-request

描述

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.
CREATE TABLE t1 (id INTEGER, sex CHAR(1));
SELECT sex, AVG(id), ROW_NUMBER() OVER w FROM t1
GROUP BY sex ASC
WINDOW w AS () ORDER BY sex DESC;
  1. What did you expect to see?

Error ASC or DESC with GROUP BY isn't allowed with window functions; put ASC or DESC in ORDER BY is thrown.

  1. What did you see instead?

Execute successfully with no warning.

  1. What version of TiDB are you using (tidb-server -V or run select tidb_version(); on TiDB)?

貢獻者指南

技術棧
gosql
領域
backenddatabase
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
SQL GROUP BY and window functionsGo language basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The issue is that TiDB should throw an error when ASC/DESC is used with GROUP BY in the presence of window functions. The fix requires locating where the SQL query is parsed and validated. The parser or planner likely accepts this syntax erroneously. Examine the parser files (e.g., `parser/ast/select.go`) and the planner rules (e.g., `planner/core/rule aggregation push down.go`) to add a check that rejects such queries. Look at similar error messages in the codebase for reference.
Error should be thrown when there's ASC/DESC with GROUP BY clause · pingcap/tidb#10522 | Good First Issue