penrose/penrose

SVG output is giving Text a random (and unused) rotation

Open

#874 建立於 2022年2月2日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)Haskell (4,756 star) (224 fork)batch import
good first issue

描述

This is the output of a Style program that doesn't specify any rotation for the Text GPI. Note the totally random numbers under transform (which seem to have no effect on the appearance of the SVG):

<text fill="#000000" fill-opacity="1" stroke="none" transform="rotate(0, 104.90760531430058, 71.40385032616138)" style="font:     12px Palatino;" x="131.00526156430058" y="79.89994407616138" width="52.1953125" height="8.677734375" ascent="8.49609375" descent="0.181640625" text-anchor="middle" alignment-baseline="middle" dominant-baseline="middle" ensureOnCanvas="true">
<title>
w.text</title>
Some text</text>

These random numbers shouldn't be assigned—and the default sampler shouldn't try assigning a random rotation to text. That definitely violates the principle of least surprise! :-)

貢獻者指南

技術棧
無
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
無
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
The bug is in the SVG output generation, likely in the code that creates the <text> element's transform attribute. Search the repository for 'rotate' in SVG related files, particularly in the Haskell source. The issue suggests there is a default sampler that assigns random rotation; locate that sampler and modify it to not apply rotation when none is specified. Check the penrose/src/ directory for rendering or output modules.