penrose/penrose

feat: Absolute Image URLs may fail due to CORS

Open

#1,036 建立於 2022年5月31日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Haskell (4,756 star) (224 fork)batch import
good first issue

描述

Describe the bug Some web servers do not have CORS properly configured. While they may not intend to block cross-origin requests, they do. If a style program in the IDE references an image on one of these servers, then the browser will block the image fetch.

To Reproduce

  1. Open the IDE
  2. Load the tree-venn-3d example.
  3. Change both hrefs in tree-venn-3d.sty to https://www.cs.cmu.edu/~jssunshi/images/ball.svg and recompile.
  4. Observe the images do not load and the CORS errors in the developer tools console.

Expected behavior This actually is the expected behavior, but people may not appreciate the browser's behavior.

An alternative may be to proxy image fetches and add the CORS headers in the HTTP response headers in the cases where the web server does not have CORS configured. A further alternative is for affected websites to configure CORS to allow cross-origin requests.

貢獻者指南

技術棧
javascripthtmlcss
領域
frontendbackend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Understanding of CORSBasic knowledge of HTTP servers
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
The issue proposes adding a proxy to fetch images with CORS headers. One approach is to modify the IDE's backend to proxy image requests, adding appropriate CORS headers. Alternatively, the frontend could use a CORS proxy service. The existing code for loading images should be examined (likely in the IDE's rendering code) to integrate the proxy. No linked PRs or comments provide additional guidance.