pastelsky/bundlephobia

Getting 404 for empty input

Open

#770 建立於 2023年4月4日

在 GitHub 查看
 (2 留言) (1 反應) (0 負責人)JavaScript (8,477 star) (250 fork)batch import
buggood first issue

描述

Describe the bug It looks like it is expected behaviour but I don't think we should allow an empty input call from the frontend.

To Reproduce Don't type anything in the search box and press enter. It takes you to https://bundlephobia.com/package which gives 404.

Expected behavior I believe we should just do nothing when the input is empty.

Let me know if the suggested fix is good and I can make a relevant PR for the same.

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
1
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
needs maintainer response
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic javascriptbasic react
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
95
研究方向
Examine the search input component (likely in SearchBar.js) to find the form submission handler. Add a conditional check to prevent navigation or API call when the input is empty. Refer to the expected behavior described in the issue.