papercups-io/papercups

Accessibility - buttons should have discernible text

Open

#885 建立於 2021年6月17日

在 GitHub 查看
 (7 留言) (1 反應) (0 負責人)Elixir (6,032 star) (566 fork)batch import
buggood first issue

描述

Describe the bug The button to toggle the chat widget doesn't have discernible text.

To Reproduce Steps to reproduce the behavior:

  1. Go to a page with the Papercups chat widget installed.
  2. Check accessibility with axe DevTools
  3. See Buttons must have discernible text issue on <button class="Papercups-toggleButton css-1lzvboz">

Expected behavior All buttons should have discernible text, so that screen readers can properly present the page to people with low or no vision.

Additional context Fixing this is basically following one of the solutions in https://dequeuniversity.com/rules/axe/4.2/button-name?application=rocketvalidator - basically adding a aria-label attribute with the text Open chat widget for example.

貢獻者指南

技術棧
reactjavascriptcsshtml
領域
frontendaccessibility
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
1
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
無
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
95
研究方向
The button with class 'Papercups toggleButton' is likely in a React component. Add an aria label attribute with the text 'Open chat widget' to this button. Ensure that if the button toggles between open and close, the aria label updates accordingly (e.g., 'Close chat widget'). Test using axe DevTools or similar. The relevant file is probably in the frontend directory, e.g., components/ToggleButton.jsx.