papercups-io/papercups

Better phone number filtering for twillio and SMS in integrations page

Open

#816 建立於 2021年5月5日

在 GitHub 查看
 (3 留言) (0 反應) (1 負責人)Elixir (6,032 star) (566 fork)batch import
enhancementgood first issue

描述

Problem Right now if you enter a phone number without the area code or have the wrong formatting in phone number section it will fail silently and not work. We should make sure that there is a country code and that it can work regardless of the text formatting

Solution It should validate that it has a country code and we shouldn't care about formatting

貢獻者指南

技術棧
elixir
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Elixir basicsphone number validation concepts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the current phone number input handling in the integrations page, likely in a Phoenix template or LiveView. Look for validation logic in lib/ or web/ directories. Consider using a library like ex phone number or implementing a simple regex for country code presence. Check comments for any existing discussions on preferred approach. The issue specifies ignoring formatting, so focus on stripping non digit characters and ensuring a length that implies a country code (e.g., >= 10 digits).