papercups-io/papercups

Rename "shout" event to "message:created"

Open

#156 建立於 2020年8月16日

在 GitHub 查看
 (6 留言) (0 反應) (0 負責人)Elixir (6,032 star) (566 fork)batch import
good first issuetech debt

描述

This name is just the default event used when generating new channels in Phoenix, but let's make our event names a bit more descriptive... we already have conversation:created and conversation:updated events, so let's be consistent and add message:created in place of shout.

(Note: we'll probably need to keep "shout" around for backwards compatibility)

貢獻者指南

技術棧
elixir
領域
backend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Elixir basicsPhoenix Channels
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
Identify all references to the 'shout' event in the codebase, likely in channel files under lib/papercups web/channels/. Rename the event to 'message:created' and ensure backward compatibility by keeping 'shout' as an alias. Update any related tests and documentation. Check issue #156 comments for any additional details or discussions on the naming.