panzarino/mlbgame

Stop converting HTTPError to ValueError in mlbgame/data.py

Open

#92 建立於 2018年4月27日

在 GitHub 查看
 (1 留言) (1 反應) (0 負責人)Python (509 star) (116 fork)batch import
enhancementhelp wantedquestion

描述

Converting HTTPError to ValueError loses valuable information about the failure. If the HTTPError itself was allowed to be raised then callers could look at the status code and determine if they want to try the call again (in the case of a 5xx error) or stop trying (4xx error).

Or maybe it could raise new exceptions defined by the mlbgame library? Fatal or Retryable?

貢獻者指南

技術棧
python
領域
backendapi
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
understanding of Python exception handlingbasic knowledge of HTTP status codes
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Look at `mlbgame/data.py` where `HTTPError` is caught and converted to `ValueError`. The issue suggests either letting the original `HTTPError` propagate or defining custom exceptions like `Fatal` or `Retryable`. Check the existing exception hierarchy in the codebase and decide which approach aligns with the library's design. Also review any comments in the issue for further discussion.
Stop converting HTTPError to ValueError in mlbgame/data.py · panzarino/mlbgame#92 | Good First Issue