palantir/blueprint

TODO: Use react-focus-lock in overlay component

Open

#6,676 建立於 2024年1月25日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: coreType: enhancementhelp wanted

描述

Environment

  • Package version(s): core v5.9+

Feature request

Follow-up to Overlay2 PR https://github.com/palantir/blueprint/pull/6656

We should try to use the react-focus-lock library to replace a bunch of bespoke focus management code dealing with focus traps and document event handlers.

貢獻者指南

技術棧
typescriptreact
領域
frontendaccessibility
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
ReactTypeScriptFocus managementBlueprint Overlay2 PR #6656
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Review the Overlay2 PR #6656 to understand the existing focus management code. Examine the current overlay component to identify the bespoke focus trap logic that can be replaced. Then integrate react focus lock by wrapping the overlay content with its FocusLock component, removing the custom event handlers. Ensure existing tests still pass and accessibility is preserved.