palantir/blueprint

Add bordered prop to the Section component

Open

#6,577 建立於 2023年11月30日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: coreType: feature requesthelp wanted

描述

Environment

  • Package version(s): BP5
  • Browser and OS versions:

Feature request

It would be nice to have a prop in the Section component called Bordered (similar to the CardList) that allows the consumer of the component to decide whether to render the border lines of Section.

In addition to removing the border, the gap between the title and the body of the section should be reduced to 15px when bordered is false. Removing just the border leaves too much space.

Examples

貢獻者指南

技術棧
reacttypescriptcss
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
ReactTypeScriptCSS
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
Start by locating the Section component source file in the Blueprint repo (likely under packages/core/src/components/section/). Examine the existing Section component props and how the CardList component implements its 'bordered' prop for reference. Implement a new 'bordered' boolean prop that toggles the border and reduces the gap between title and body to 15px when false. Update the component's styles accordingly, possibly using CSS modules or Blueprint's style system. Ensure the changes are consistent with BP5 conventions. There is one comment on the issue from Feb 2024 asking for status, no PR linked.