palantir/blueprint

DateRangeInput2 parseDate user entering an invalid date returns valid date

Open

#6,412 建立於 2023年9月26日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
Package: datetimeType: bughelp wanted

描述

Environment

  • Package version(s):
    • Blueprint v4.20.2, Datetime v4.4.37, Datetime2 v0.9.37.
    • Blueprint v5.x DateRangeInput3
  • Operating System: macOS Sonoma 14.0.0
  • Browser name and version: Google Chrome Version 118.0.5993.117 (Official Build) (x86_64)

Problem

Blueprint 4's DateRangeInput2's parseDate()

parseDate() returns a valid date even if the user inputs an invalid date (it returns the current date). This means that onError is never called based on this logic.

This is also present in Blueprint 5's DateRangeInput 3's parseDate().

Code sandbox

https://codesandbox.io/s/clever-snow-65sg9m?file=/src/App.js

Steps to reproduce

Using the sandbox:

  1. Type 01-Jan-2023, 00:00 into the Start date
  2. Type abcdef into the End Date

https://github.com/palantir/blueprint/assets/50017873/2a879499-5296-491f-9f0e-4732c899b34b

Actual behavior

Today's date is entered into the End date.

Expected behavior

The 'Invalid date' is entered into the End date.

Solution

Perhaps revert back to Blueprint v3's implementation return newDate === false ? new Date(undefined) : newDate;

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactTypeScriptBluepr]int basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue is in the parseDate function of DateRangeInput2 (v4) and DateRangeInput3 (v5) components. Look at the linked source files: dateRangeInput2.tsx line 1038 and dateRangeInput3.tsx line 936. The bug is that parseDate returns the current date when input is invalid, preventing onError from being called. A suggested fix is to revert to Blueprint v3's implementation which returns new Date(undefined) for invalid input. Check the code sandbox for reproduction. Review the current implementation and ensure the fix aligns with expected behavior.