palantir/blueprint

Expanding a tree with many child nodes that have ContextMenu is very slow

Open

#6,204 建立於 2023年6月6日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
Domain: performanceP2Package: coreType: bughelp wanted

描述

Environment

  • Package version(s): The latest @blueprintjs/core@4.20.1, @blueprintjs/popover2@1.14.9
  • Operating System: macOS
  • Browser name and version: Edge/Chrome

Code Sandbox

https://codesandbox.io/p/sandbox/festive-rgb-j35zpp

Actual behavior

If the tree node has many children nodes, and these children nodes are wrapped with ContextMenu2, when expanding the tree node, it's stuck for seconds to expand its children. If the ContextMenu2 is removed, the expanding is very smooth.

The sandbox uses the treeExample from the blueprint itself and makes a little change to demonstrate this problem.

貢獻者指南

技術棧
typescriptreact
領域
frontendperformance
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactPerformance debuggingTree componentContextMenu
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Reproduce the slowdown using the provided CodeSandbox (https://codesandbox.io/p/sandbox/festive rgb j35zpp). Profile the tree expansion with React DevTools to pinpoint the culprit. Inspect the Tree and ContextMenu2 source code in the Blueprint repository to understand the rendering flow. Consider using React.memo or virtualization to reduce the number of context menus rendered at once.