palantir/blueprint

[V5] ContextMenu does not lazy render popover anymoe

Open

#6,171 建立於 2023年5月23日

在 GitHub 查看
 (4 留言) (1 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: coreType: bughelp wanted

描述

Environment

  • Package version(s): 5.0.0-alpha.3
  • Operating System: MacOS
  • Browser name and version: Chrome

Steps to reproduce

  • We're migrating ContextMenu2 --> ContextMenu, but see some degrade in performance for some of our table.

Actual behavior

  • Lots of portal divs are created in advance, this is not happening with ContextMenu2, it used to be lazy, 2023-05-24-001917_611x460_scrot

  • I am trying to pass lazy: true to popoverProps but TypeScript complaining, apparently because we only pick a handful of props.

Expected behavior

  • lazy should be the default, like it was with ContextMenu2

Possible solution

I'm not too sure this time...

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
ReactTypeScriptBlueprint components
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
35
研究方向
Investigate the ContextMenu component source in the Blueprint repository (e.g., src/components/context menu/contextMenu.tsx). Compare with the deprecated ContextMenu2 to understand how lazy rendering was implemented before. Check the Popover component's lazy prop and why it's not exposed. Look at recent comments for maintainer suggestions. Possibly submit a PR to make lazy default or add the prop back.