palantir/blueprint

Vertical Misalignment when NumericInput is wrapped in a Label (visual bug)

Open

#6,030 建立於 2023年3月17日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: coreType: bughelp wanted

描述

Environment

  • Package version(s): 4.17.6
  • Operating System: MacOS Ventura
  • Browser name and version: Chrome version 111.0.5563.64

Code Sandbox

Link to a minimal repro: Sandbox

Steps to reproduce

  1. Visual bug (appearance)

Actual behavior

Placing NumericInput inside Label causes vertical misalignment of the text input as there is an additional 5px top margin on the text input.

Expected behavior

The text inputs and button inputs should be vertically aligned.

Possible solution

Add CSS property to default the margin-top to 0 on the text input for NumericInput so that even if it is wrapped in a Label there aren't additional margins.

貢獻者指南

技術棧
typescriptreactcss
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
CSSReact components
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
90
研究方向
The issue reports a vertical misalignment when NumericInput is wrapped in a Label. The suggested fix is to add CSS property `margin top: 0` to the text input in NumericInput. The developer should locate the CSS file for NumericInput (likely in the Blueprint source under `packages/select/src/` or similar) and add the rule. Verify that the fix doesn't break other use cases where NumericInput is not wrapped in a Label. The issue has no linked PRs or assignees, so it's open for contribution.