palantir/blueprint

Overlay enforcing focus not returning focus to the last focused element in the overlay

Open

#5,857 建立於 2023年1月20日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P3Package: coreType: bughelp wanted

描述

Environment

  • Package version(s): 8.5.5
  • Operating System: macOS Ventura 13.1 (22C65)
  • Browser name and version: Version 109.0.5414.87 (Official Build) (arm64)

Code Sandbox

Link to a minimal repro (fork this code sandbox): https://codesandbox.io/s/exciting-greider-3u7620

Steps to reproduce

  1. Start typing in the overlay's input box.
  2. Wait 2 seconds.
  3. Notice how the focus is not returned to the input box but instead to the overlay's root element.

Expected behavior

I'd expect the focus to be returned to the last focused element in the overlay. Otherwise, it's particularly problematic for omnibars.

貢獻者指南

技術棧
typescriptreact
領域
frontendaccessibility
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactTypeScriptDOM focus API
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Investigate the Overlay component's focus management logic in the source code (likely in packages/core/src/components/overlay). Understand how the component saves and restores focus. Verify that the last focused element is correctly tracked before the overlay appears. Consider adding a test that simulates the user's behavior. The issue mentions a sandbox, so you can reproduce the problem there.