palantir/blueprint

Blueprint v5 popover auto placement is different from v4

Open

#5,760 建立於 2022年11月18日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
Domain: APIPackage: popover2help wanted

描述

Environment

  • Package version(s): @blueprintjs/popover2 v1.10.0

Code Sandbox

Link to a minimal repro: https://sdlqfs.csb.app/

Problem

When configuring Popover2 with rootBoundary="viewport" or rootBoundary="document", the automatic popper.js placement has different behavior compared to Popover. This may be expected and a bugfix in some cases since the positioning engine has improved, but it may be unexpected in other cases.

There may be something we can improve here by setting / unsetting boundary and rootBoundary options on the various modifiers based on user-specified props. For example, I'm not sure that it's "correct" that we set boundary: "clippingParents" (applying the default) when the rootBoundary prop is defined: https://github.com/palantir/blueprint/blob/2460933e7084632f9f8b4f193fcda9fb9b3fd38f/packages/popover2/src/popover2.tsx#L493

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Understanding of Popper.js modifiersFamiliarity with Blueprint Popover2 API
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
The issue describes a difference in auto placement behavior between Blueprint Popover v4 and Popover2 v5 when using `rootBoundary` prop. The reporter points to a specific line (L493) in popover2.tsx where `boundary: 'clippingParents'` is set even when `rootBoundary` prop is provided. Research should examine the Popover2 source code, particularly the modifiers configuration, to understand how boundary and rootBoundary options interact. The goal is to determine if the current behavior is intended or if adjustments are needed to align with v4 behavior. No pull requests or assignees are present, so this issue is available for exploration.