palantir/blueprint

Modifying the time doesn't show up on the timepicker in DateRangePicker

Open

#5,502 建立於 2022年8月22日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: datetimeType: bughelp wanted

描述

Environment

  • Package version(s): 4.3.4
  • Operating System: MacOS Monterey
  • Browser name and version: Firefox 103.0.2

Code Sandbox

Link to a minimal repro: https://codesandbox.io/s/blueprint-sandbox-forked-gb14b7

Steps to reproduce

  1. Select two dates in the daterangepicker

Actual behavior

Modifying the endTime (from 00:00 to 23:59) doesn't show the modified end time in the time picker. (I modify the time in the onChange)

Expected behavior

When I change the time on the endDate value, it should update on the DateRangePicker end time

Possible solution

It looks like it doesn't update the startTime or endTime in the code when the props change, only on the construction. Modify it so it does do that.

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
React state managementBlueprint component API
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Investigate the DateRangePicker component source code, specifically the handling of startTime and endTime props. Look at the constructor and componentDidUpdate methods in src/components/date range picker/dateRangePicker.tsx to see why time changes do not propagate. Check if the component re renders correctly when props change and consider adding a componentDidUpdate or getDerivedStateFromProps to sync state.