palantir/blueprint

Modifying the time doesn't show up on the timepicker in DateRangePicker

Open

#5,502 建立於 2022年8月22日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)TypeScript (2,167 fork)batch import
P2Package: datetimeType: bughelp wanted

倉庫指標

Star
 (20,263 star)
PR 合併指標
 (平均合併 43天 10小時) (30 天內合併 27 個 PR)

描述

Environment

  • Package version(s): 4.3.4
  • Operating System: MacOS Monterey
  • Browser name and version: Firefox 103.0.2

Code Sandbox

Link to a minimal repro: https://codesandbox.io/s/blueprint-sandbox-forked-gb14b7

Steps to reproduce

  1. Select two dates in the daterangepicker

Actual behavior

Modifying the endTime (from 00:00 to 23:59) doesn't show the modified end time in the time picker. (I modify the time in the onChange)

Expected behavior

When I change the time on the endDate value, it should update on the DateRangePicker end time

Possible solution

It looks like it doesn't update the startTime or endTime in the code when the props change, only on the construction. Modify it so it does do that.

貢獻者指南