palantir/blueprint

Locale = English does not display comma separators

Open

#5,405 建立於 2022年6月28日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: coreType: feature requesthelp wanted

描述

https://blueprintjs.com/docs/#core/components/numeric-input Typing "1000000" with locale set to English does not convert the display format to "1,000,000", contrary to https://github.com/palantir/blueprint/blob/develop/packages/docs-app/src/examples/core-examples/common/locales.tsx#L20

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with Blueprint's NumericInput componentBasic understanding of JavaScript Intl.NumberFormat
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
Examine the locale.tsx file (packages/docs app/src/examples/core examples/common/locales.tsx) to understand the locale configuration. Then review the NumericInput component implementation, likely in packages/core/src/components/numeric input, to see how number formatting is applied. Check if Intl.NumberFormat is used and whether the issue is due to missing options for grouping separators. Also look at the comments on the issue for any additional context or hints from maintainers. If possible, test the behavior with different locales.