palantir/blueprint

[FormGroup] Using both `inline` and `subLabel` props produce misaligned `subLabel`s

Open

#5,294 建立於 2022年5月9日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: coreType: bughelp wanted

描述

Environment

  • Package version(s): @blueprintjs/core 4.3.0

Steps to reproduce

  1. Use a FormGroup with both inline and subLabel props.
<FormGroup
    inline={true}
    label="Label"
    labelFor="text-input"
    labelInfo="(required)"
    subLabel="Label helper text with details..."
>
    <InputGroup id="text-input" placeholder="Placeholder text" />
</FormGroup>

Actual behavior

Screenshot from the docs example page:

image

Expected behavior

The subLabel appears aligned with something, so either:

  • The subLabel appears below the label/labelInfo?
  • The subLabel appears above the input?

貢獻者指南

技術棧
typescriptreactcss
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
React basicsCSSBlueprint FormGroup component
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue is about misaligned subLabel in FormGroup when both inline and subLabel props are used. Start by examining the FormGroup component source code in the Blueprint repository, likely in `packages/core/src/components/forms/formGroup.tsx`. The CSS styles for `.bp4 form group` and `.bp4 label` might need adjustment for the inline variant. Reproduce the issue locally and inspect the rendered HTML to determine the root cause. The fix could involve adjusting CSS flexbox properties or the order of elements. Check if there are any existing tests for FormGroup in `packages/core/test/forms/formGroupTests.tsx`.
[FormGroup] Using both `inline` and `subLabel` props produce misaligned `subLabel`s · palantir/blueprint#5294 | Good First Issue