palantir/blueprint

Enabled anchor buttons don't trigger the onClick callback if the button is immediately disabled after being clicked. Buttons do.

Open

#5,245 建立於 2022年4月7日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P3Package: coreType: bughelp wanted

描述

Environment

  • Package version(s):
  • Operating System:
  • Browser name and version:

Code Sandbox

I have a button that I only want to be enabled when a certain element has focus. When the user clicks the button, that element will no longer have focus so the button will no longer be enabled, but I want the initial click to go through and trigger the onClick callback. I am seeing this work with <Button /> but not <AnchorButton />. It'd be nice if when I clicked an enabled anchor button, the onClick callback went through even if I immediately disable the button. I can't just use a Button instead because I also want to show a tooltip on the disabled button which AnchorButtons are recommended for.

Bug report Package version(s): Browser and OS versions:

Expected behavior When I click an enabled button, the callback is run

Steps to reproduce

  1. Have an anchor button that is disabled when a given element doesn't have focus and has an onclick callback

  2. Click the button

  3. The callback isn't run

  4. Repeat the above with a normal Button

  5. The callback is run

Actual behavior

If I click a button while it's enabled and then immediately disabled it, the callback isn't run

Expected behavior

When I click an enabled button, the callback is run

Possible solution

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
React basicsBlueprint components
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Investigate the difference in event handling between AnchorButton and Button components in Blueprint. Look at the source code for both components, likely in packages/blueprintjs/core/src/components/button/buttons.tsx. Check how the onClick event is attached and if there's a check for disabled state that prevents the callback. Consider whether a ref or callback ref approach could ensure the click event is captured before disabling. Also review any existing test files for button components to understand expected behavior.
Enabled anchor buttons don't trigger the onClick callback if the button is immediately disabled after being clicked. Buttons do. · palantir/blueprint#5245 | Good First Issue