palantir/blueprint

[Select] Can't select item by keyboard - Enter

Open

#5,191 建立於 2022年3月22日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: selecthelp wanted

描述

Can't select item by keyboard Enter If replace Button via native button html tag, and set filterable={false}.

Environment

  • Package version(s):
  • Operating System:
  • Browser name and version:

Code Sandbox

Link to a minimal repro: https://codesandbox.io/s/blueprint-sandbox-forked-x7z0uz?file=/src/SelectExample.tsx

Loom: https://www.loom.com/share/2639f8abedff41ac84fe02a7548f0574

Steps to reproduce

  1. child components - native button
  2. filterable={false}
  3. Use Keyboard to select active item

Actual behavior

Can't select item, only if i pressed Enter second time

Expected behavior

Select item by keyboard Enter

貢獻者指南

技術棧
typescriptreacthtmlcss
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic React knowledgeTypeScript familiarity
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Investigate the Select component's keyboard event handling when `filterable={false}` and the item is a native `<button>`. Check the code sandbox for exact behavior. Look in the repository's source code for the Select component, particularly the `onKeyDown` or similar handlers that manage Enter key selection. The issue likely involves a conditional that skips selection on first press due to filterable=false. Examine related comments in the issue for additional clues.