palantir/blueprint

Multiple re-rendering by useHotkey

Open

#5,178 建立於 2022年3月17日

在 GitHub 查看
 (4 留言) (1 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
Domain: performanceP2Package: coreType: bughelp wanted

描述

Inside List components (Row) have empty hotkeys. On Scrolling list - rendering Row causes App with use useHotkey to re-render.

Environment

  • Package version(s): @blueprintjs/core v4.0.0-rc.0, react-virtualized v9.22.3
  • Operating System: Mac os 12.2.1
  • Browser name and version: Chrome 99.0.4844.51

Code Sandbox

Code sandbox

Steps to reproduce

Loom - https://www.loom.com/share/f6ad7a40cdd94bc08a2f36f7ac23a5db

Actual behavior

Component is re-rendering when scrolling List

Expected behavior

Component doesn't re-rendering when scrolling List

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
React hooksuseHotkey
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
55
研究方向
The issue is that useHotkey causes re renders when scrolling a list with empty hotkeys. First, review the useHotkey implementation in the Blueprint codebase (likely in packages/core/src/components/hotkeys/). Check if it uses useEffect or useMemo correctly. Then, inspect the provided CodeSandbox to reproduce and identify the root cause. Discuss potential fixes like memoization or conditional effect dependencies.