palantir/blueprint

Consider refactoring overlays to use <dialog> element

Open

#5,120 建立於 2022年2月9日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: coreStatus: needs proposalType: enhancementhelp wanted

描述

Feature request

The <dialog> element provides a lot of functionality and affordances out of the box. It is supported in all major browsers except IE11, which we are dropping support for in Blueprint v5.0. We should investigate whether migrating our <Overlay> implementation to use this built-in element can reduce our code complexity and maintenance cost.

Related

貢獻者指南

技術棧
typescriptreacthtmlcss
領域
frontendaccessibility
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
3-5 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Familiarity with ReactUnderstanding of Blueprint's Overlay componentKnowledge of HTML dialog element
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Examine the current implementation of the Overlay component in the Blueprint repository. Review the linked CSS Tricks article for dialog best practices. Investigate browser compatibility and potential polyfills. Consider the impact on existing Overlay features and test coverage. Look for any open issues or discussions about dialog migration in the repository.