palantir/blueprint

Cannot use Enter key in dialog/textarea spawned from Table

Open

#5,042 建立於 2021年11月29日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: corePackage: tableType: bughelp wanted

描述

Environment

  • Package version(s): table 3.9.12, core 3.49.1
  • Operating System: windows
  • Browser name and version: firefox and chrome

Code Sandbox

https://codesandbox.io/s/blueprint-sandbox-forked-r06o8?file=/src/index.tsx

image

Actual behavior

Cannot insert new lines by typing Enter in textarea in dialog which is a child of a Table

It behaves as if the table intercepted the Enter key. All other keys seem to work normally. It is possible to insert new lines by pasting (Ctrl-V).

Expected behavior

Can use the Enter key in textarea of dialog which is a child of a Table

Possible solution

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic ReactEvent handling in React
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
The issue is that the Table component intercepts the Enter key event, preventing it from reaching a textarea inside a Dialog. Investigate the Table's key event handling code, likely in src/components/table/ or similar. Look for any event.stopPropagation() or event.preventDefault() on Enter key. The fix may involve not propagating the event when the target is a textarea or dialog. Check the existing comments for any hints.