palantir/blueprint

Hotkey should show "option" text on macOS instead of "alt"

Open

#4,959 建立於 2021年10月7日

在 GitHub 查看
 (0 留言) (3 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: coreType: bughelp wanted

描述

Environment

  • Package version(s): blueprintjs core v3.51.0
  • Browser and OS versions: All browsers; macOS

Feature request

The text for Hotkey when combo has the word "option" should display "option" as the associated text on macOS instead of "alt". This is similar to how "mod" is "cmd" or "ctrl" depending on the operating system.

Examples

<Hotkey
    global
    combo="option"
    label="Test"
    preventDefault
    onKeyDown={() => console.log('test')}
/>

Currently, it automatically renames "option" to "alt" when passed into combo:

Should be:

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactTypeScriptHotkey component structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Investigate the Hotkey component's key normalization logic, likely in the source files under packages/core/src/components/hotkey. Find where 'mod' is mapped to 'cmd' or 'ctrl' based on OS. Replicate that pattern to map 'option' to display 'option' on macOS and 'alt' on other platforms. Check existing tests for the component to ensure the change is covered and does not break existing behavior.