palantir/blueprint

[node-build-scripts] sass-lint path logic is broken

Open

#4,942 建立於 2021年9月30日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
Domain: toolingP2Type: bughelp wanted

描述

Environment

  • Package version(s): node-build-scripts v1.6.x

Steps to reproduce

  1. Use sass-lint.js script outside of this repo, through @blueprintjs/node-build-scripts

Actual behavior

It always fails to find .stylelintrc because it's looking inside the node_modules folder where the scripts package is installed.

Expected behavior

The script is usable outside this repo...

Possible solution

Use process.cwd() instead of __dirname, and also allow a CLI argument to override the configFile option

貢獻者指南

技術棧
javascriptnodejs
領域
build systemdeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
node.jsprocess.cwd()cli arguments
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
The script uses dirname to find .stylelintrc, which fails when used externally. The fix is to replace dirname with process.cwd() and optionally accept a config CLI argument. The relevant file is likely sass lint.js in the node build scripts package. No discussion has occurred, so first time contributors should verify with maintainers before working.