palantir/blueprint

FR: InputGroup aria-label can be inferred from placeholder

Open

#4,874 建立於 2021年8月24日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
Domain: accessibilityP2Type: feature requesthelp wanted

描述

Environment

  • Package version(s): core 3.48.0

Feature request

<InputGroup> could have better accessibility if it applied an aria-label to its <input>. If the placeholder prop exists, we should use that value. We'll need to consider how this interacts with <FormGroup> and wrapping <label> elements (we don't want to label the input twice).

貢獻者指南

技術棧
typescriptreacthtmlcss
領域
frontendaccessibility
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactAccessibility basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
The main file to modify is packages/core/src/components/input group/inputGroup.tsx. Look for the <input> element and add an aria label attribute that uses the placeholder prop when no label is provided. Consider the interaction with FormGroup by checking if the input is already labeled via a wrapping <label> or FormGroup's label prop. Review the FormGroup component in packages/core/src/components/form group/formGroup.tsx to understand how labeling works. Ensure not to duplicate aria labels.