palantir/blueprint

Can we have a ContextMenu2 with an arrow like we have in Popover2? Arrow modifier doesn't work for me.

Open

#4,865 建立於 2021年8月20日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: popover2Type: feature requesthelp wanted

描述

Environment

  • Package version(s): "@blueprintjs/core": "^3.10.0", "@blueprintjs/popover2": "^0.11.1",
  • Browser and OS versions: MacOS Catalina Version 10.15.7 Browser Firefox 91.0.1

Question

I would need a context menu but with an arrow just like a popover (screenshot below), which points to the clicked screen coordinates on the clicked component.

I saw two solutions:-

  1. Opening Popover2 on right-click
  2. Adding arrow: { enabled: true } modifier as a prop in ContextMenu2

But AFAIK, opening Popover2 with right-click isn't possible according to the official documentation, right?

And, providing this modifier didn't work.

<ContextMenu2
  modifiers={{ arrow: {enabled: true} }}
  content={<p>hello world</p>}
>
  Click me to open menu
</ContextMenu2>

image

Can someone please share a snippet in JS? Thanks a lot.

貢獻者指南

技術棧
reacttypescript
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactBlueprint basicsPopover2 modifier usage
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate why the `arrow` modifier does not work in ContextMenu2 despite it working in Popover2. Compare the source code of both components, focusing on how modifiers are passed and applied. Check if ContextMenu2 explicitly disables the arrow or if the modifier is being overridden. Look at the relevant files in the Blueprint repository, such as `packages/popover2/src/contextMenu2.tsx` and `packages/popover2/src/popover2.tsx`. Consider if a new prop like `hasArrow` is needed or if the existing modifier support simply needs to be enabled.