palantir/blueprint

LabelElement Icon doesn't highlight on hover in dark mode

Open

#4,809 建立於 2021年7月19日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: coreType: bughelp wanted

描述

Environment

  • Package version(s): 3.46.0
  • Operating System: MacOS Catalina
  • Browser name and version: Chrome

Code Sandbox

Link to a minimal repro: https://blueprintjs.com/docs/#core/components/menu

Steps to reproduce

View the menu item behavior shown in the link above. This is just a comment on the current features of the menu item component.

Actual behavior

The right icon (labelElement) does not highlight on hover in dark mode unlike the left icon.

Expected behavior

The right icon should highlight on hover in dark mode like the left icon, at least for cases where there is only the right icon being rendered.

Possible solution

Add a highlight styling on hover for the labelElement.

貢獻者指南

技術棧
cssreacttypescript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
1
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic CSSfamiliarity with Blueprint theming
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
90
研究方向
The fix involves adding a CSS rule for the labelElement hover state in dark mode. Look at the Menu component's styles, likely in the `packages/core/src/components/menu/` directory. The issue suggests adding a hover style similar to the left icon's hover effect. Check the existing hover styles for menu items and replicate for `.bp3 menu item .bp3 file label` (or similar selector) in dark mode. No linked PR or assignee, so the issue is available for contribution.