palantir/blueprint

Editable Cell with enableFocusedCell stealing focus

Open

#4,796 建立於 2021年7月2日

在 GitHub 查看
 (0 留言) (1 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: tableType: bughelp wanted

描述

Environment

Package version(s): @blueprintjs/table 3.7.1 Operating System: MacOS Catalina 10.15.7 Browser name and version: Chrome Version 91.0.4472.114

Code Sandbox

https://codesandbox.io/s/enablefocusedcell-bug-0m19u

Steps to reproduce

  1. Enter a value into any cell (do not do anything to confirm the value ie press enter)
  2. Click the red div (or anywhere outside the table...thus confirming the cell)
  3. press any key
  4. See the cell listens for the keypress

Actual behavior

Although there has been an interaction outside of the table, the cell is still the active element (see console) and steals the next keypress.

Expected behavior

I would expect once there has been a user interaction outside the table, the cell should not listen for keypresses.

Possible solution

I believe the focus is being forced by this function which runs on every render https://github.com/palantir/blueprint/blob/5c05ce6bb12a9810b9ff35310a1554a65af6b65d/packages/table/src/cell/editableCell.tsx#L214-L219

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactDOM focus events
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue indicates that the `editableCell` component forces focus on every render via the `handleCellFocus` function in `packages/table/src/cell/editableCell.tsx` (lines 214-219). To fix, investigate why focus is being forced and ensure it only occurs when the cell should be focused, not after user interaction outside the table. Consider checking if the cell is still the active element or if a blur event has occurred.