palantir/blueprint

DateInput popover opens again after editing hours or minutes

Open

#4,776 建立於 2021年6月23日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: datetimeType: bughelp wanted

描述

Environment

  • Environment
  • Package version(s):
    • "@blueprintjs/core": "3.31.0"
    • "@blueprintjs/datetime": "^3.23.4"
  • Operating System: Mac OS 10.15.7
  • Browser name and version: Chrome 91.0.4472.114

Code Sandbox

Link to a minimal repro: https://codesandbox.io/embed/popover-popping-up-again-n5r7v?fontsize=14&hidenavigation=1&theme=dark

Steps to reproduce

  1. Have time showing in the DateInput
  2. Select any date
  3. Edit either the hour or minute inputs inside the popover (not directly in the date input)
  4. Click outside of the popover to close

Actual behavior

The popover reopens itself. Note this does not happen with seconds.

Expected behavior

The popover should close.

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic knowledge of Reactunderstanding of popover behavior
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the DateInput component in the Blueprint codebase, focusing on the popover close logic. The bug occurs when editing hours or minutes (but not seconds) inside the popover. Check the onChange and onClose handlers in the DateInput component, specifically how the popover state is managed. Look at the linked CodeSandbox for reproduction. The fix likely involves preventing the popover from reopening after a valid edit or modifying the blur event handling.