palantir/blueprint

Text overflow wrapping for time picker

Open

#4,702 建立於 2021年5月7日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: datetimeType: feature requesthelp wanted

描述

I think it would be helpful to support time wrapping for time picker when using the arrow keys. It seems unintuitive for 4:00 -> arrow down -> 4:59 instead of wrapping to 3:59.

Currently workarounds are not possible since origin of time change (hours, minutes seconds) and direction of change are not accessible from the onChange callback.

Thank you for your consideration!

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
無
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Look into the TimePicker component in the Blueprint repository (likely in packages/core/src/components/time picker/). Investigate how arrow key handling currently works (onArrowKeyDown or similar) and implement wrapping logic to allow minute/hour cycling. Update the onChange callback to expose the origin and direction of time change if needed.