palantir/blueprint

One and two digits years are handled incorrectly

Open

#4,575 建立於 2021年3月10日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P3Package: datetimeType: bughelp wanted

描述

Environment

  • Package version(s): "@blueprintjs/datetime@3.20.5"
  • Operating System: Windows 10 Pro 18363.1379
  • Browser name and version: Chrome 88.0.4324.190 (Official Build) (64-bit)
  • Component: DateInput

Code Sandbox

Please check the example by sandbox link

Preliminary steps which are performed in the example:

  1. set formatDate and parseDate attributes using moment (moment returns expected result)
  2. set minDate as new Date("0001-01-01T00:00:00.000Z")

scenario 1:

Steps to reproduce

  1. enter "0001-01-01" in the date input
  2. check date picker

Actual behavior

The date picker displays "1901" in the year select field and the day is not highlighted

Expected behavior

The date picker displays "1" in the year select field or "0001" and the picked day highlighted

image

scenario 2:

Steps to reproduce

  1. click on the input
  2. pick any two digits year or one digit year from the date picker, for example, "12"

Actual behavior

The input field displays "1912-01-01" and the date picker displays "1912" in the year select field

Expected behavior

The input field displays "0012-01-01" and the date picker displays "12" in the year select field or "0012"

image image

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactTypeScriptdate parsing
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the DateInput component in the @blueprintjs/datetime package. Look at the parseDate and formatDate functions to understand how years are parsed and formatted. The issue indicates that one and two digit years are incorrectly interpreted as 1900s instead of being treated as literal years. Check if there is any padding or conversion logic that adds 1900 or 2000. The code is likely in packages/datetime/src/dateInput.tsx or similar. The example uses moment.js, but the issue may be in Blueprint's internal handling.
One and two digits years are handled incorrectly · palantir/blueprint#4575 | Good First Issue