palantir/blueprint

Some mechanism for letting EditableText shrink to its content size when not editing

Open

#4,543 建立於 2021年2月25日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: coreType: enhancementhelp wanted

描述

So this mostly already happens, but the min-width on the inner span is set to 80px. Have a UI like this:

Without doing some css hacking to unset the min-width, it ends up looking like this:

css hacking I'm doing is:

.display-name-value {
    max-width: 250px;

    > :last-child {
        // Need our EditableTexts to contract to their content size
        /* stylelint-disable declaration-no-important */
        min-width: unset !important;
        /* stylelint-enable declaration-no-important */
    }
}

but that's obviously really flaky, so was hoping for a more formal way to remove/lower the min-width (unset isn't necessarily correct because you get into a weird spot if you don't have a placeholder, but want the ability to make it lower than 80px at least)

貢獻者指南

技術棧
typescriptreactcss
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactCSSBlueprint component basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Examine the EditableText component in the Blueprint repo (likely in packages/core/src/components/editable text). The issue requests a formal mechanism to control or remove the hardcoded min width on the inner span (currently 80px). Consider adding a prop like `shrinkToContent` or `minWidth` that defaults to 80px but can be set to smaller or 'unset'. Look at existing styling logic for the span and how props are passed to the component's state. No linked PRs or comments provide guidance, so the solution should be a non breaking addition.