palantir/blueprint

`createNewItemFromQuery` fired on every key press

Open

#4,510 建立於 2021年1月28日

在 GitHub 查看
 (6 留言) (1 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: selectType: bughelp wanted

描述

Environment

  • Package version(s): @blueprintjs/core3.38.1 @blueprintjs/icons3.24.0 @blueprintjs/select3.15.3
  • Operating System: Mac OS 11.1
  • Browser name and version: Safari 14.0.2; Chrome 88.0.4324.96

Sandbox

https://stackblitz.com/edit/blueprint-select-create-new-item-bug?file=src/App.js

Steps to reproduce

  1. Open the stackblitz dev console or your web browser's console.
  2. Type anything into the suggest box.
  3. Observe that "create new tag" is called every time you type a new character.

Actual behavior

createNewItemFromQuery is being fired on every key press, and not just by (from the docs) "pressing the Enter key or by clicking on the "Create Item" option".

Expected behavior

createNewItemFromQuery should only fire when pressing the Enter key or when clicking on the "Create Item" option.

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactTypeScriptBlueprint select
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Investigate the `Suggest` component in `@blueprintjs/select` to locate where `createNewItemFromQuery` is called. The bug indicates it fires on every key press rather than only on Enter or click. Examine the key press event handlers and the logic that triggers the creation. The expected behavior is that it should only be invoked when the Enter key is pressed or when the user clicks the 'Create Item' option. Check the component's state management and look for any recent changes that might have introduced this regression. The sandbox provided should help reproduce the issue.