palantir/blueprint

MultiSelect triggers wrapping form

Open

#4,461 建立於 2020年12月17日

在 GitHub 查看
 (2 留言) (5 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
Form componentsP2Package: corehelp wanted

描述

Environment

  • Package version(s): select 3.15.0
  • Operating System: Docker / node 14
  • Browser name and version: Chrome latest

Code Sandbox

Link to a minimal repro (fork this code sandbox): https://codesandbox.io/s/blueprint-sandbox-forked-cnc83?file=/src/index.tsx

Steps to reproduce

  1. Create a MultiSelect
  2. Place it inside a form
  3. Select a value, confirm with enter

Actual behavior

The form is submitted.

Expected behavior

The value is added to the tag list and the form remains un-submitted.

Possible solution

Doing event.stopPropagation and event.preventDefault in the onItemSelect handler does not help. Same with overriding tagInputProps.onChange.

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Reactevent handling
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate MultiSelect component's key event handling in packages/select/src/components/multi select/multiSelect.tsx. Focus on how the Enter key is processed and whether event.preventDefault is correctly called. Check if the form submission is triggered by a missing stopPropagation on the keydown event. Also review any existing comments or linked issues for insights.