palantir/blueprint

Date Range Input: Time is not updating onHoverChange event

Open

#4,402 建立於 2020年11月8日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P3Package: datetimeType: bughelp wanted

描述

Environment

  • Package version(s): 3.30.1
  • Operating System: MAc OS Catlina
  • Browser name and version: Chrome latest

Code Sandbox

Actually the bug can be visible in the documentation itself so adding Screenshot of it here

Steps to reproduce

Enable Time Precision with minute or seconds

  1. Click Start Date Field (so Date Picker opens).
  2. Select preferred date for both start and end fields.
  3. Please Add time in the below boxes for hours, minutes, seconds.
  4. Now Hover the different date in Date Picker and you can see start date in input field changes as per the hover state but the time value will be the default time itself (12:00)
  5. The same happens in end date field too.

Actual behavior

As we can clearly see the time is not changing and stays still with 12:00 during hovering of dates

Expected behavior

We should get the time from the value and update the time too when we hover Defaulting to 12:00 and changing immediately back to user selected time causes confusion

Possible solution

DateRangePicker props and callback function should be updated with props time i guess

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactTypeScriptDateRangePicker API
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
55
研究方向
Investigate the DateRangePicker component, specifically the onHoverChange event handler. Check how time values are preserved during hover. Look at the source code for DateRangePicker in the Blueprint repository, likely in the 'packages/date time' folder. Review the props and state management for time precision settings. Consider if the time should be taken from the already selected value instead of defaulting to 12:00.