palantir/blueprint

Omnibar selects first entry on empty query

Open

#4,330 建立於 2020年9月11日

在 GitHub 查看
 (0 留言) (1 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: selectType: bughelp wanted

描述

Environment

  • Package version(s): 3.31.0
  • Operating System: macOS 10.15.6
  • Browser name and version: Chrome 85.0.4183.83

Steps to reproduce

  1. Visit https://blueprintjs.com/docs/#select/omnibar
  2. Open the omnibar (there are no movies displayed)
  3. Press enter
  4. A toast "You selected The Shawshank Redemption." will appear

Actual behavior

An empty search string still selects the first entry in the list.

Expected behavior

Nothing.

貢獻者指南

技術棧
typescriptreactcss
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic React knowledgeFamiliarity with Blueprint components
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
Examine the Omnibar component in the Blueprint repository, likely in `packages/select/src/components/omnibar/`. Focus on the logic that handles key presses or selection when the query is empty. Look for a missing conditional check that prevents selecting the first item when the query is an empty string. Review the component's state and the `handleKeyDown` or similar method to identify where the fix should be applied.