palantir/blueprint

NumericInput controlled mode warns about invalid value too often

Open

#4,327 建立於 2020年9月10日

在 GitHub 查看
 (1 留言) (9 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: coreType: enhancementhelp wanted

描述

Environment

  • Package version(s): core 3.31.0

Steps to reproduce

  1. set up <NumericInput value={this.state.value} onChange={(_v, value) => this.setState({ value })) />
  2. type 0.

Actual behavior

in dev mode, the component complains that

<NumericInput> controlled value prop does not adhere to stepSize, min, and/or max constraints.

2020-09-10 13 38 22

Expected behavior

this should be allowed. what it actually means is that the string passed was not a full numeric entity, but it can still be parsed as a valid number, so it's ok.

Possible solution

change the validation logic

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
ReactTypeScriptBlueprint basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the NumericInput component's validation logic, likely in src/components/forms/numericInput.tsx or similar. The current validation rejects strings like '0.' that are not full numeric entities but parse to valid numbers. The fix should allow such intermediate values during typing while still enforcing constraints on final value. Consider using a regex or parsing function that accepts incomplete numbers.