palantir/blueprint

ItemPredicate make onActiveItemChange fired twice and active item isn't the good one

Open

#4,192 建立於 2020年6月25日

在 GitHub 查看
 (4 留言) (5 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: selectType: bughelp wanted

描述

Environment

  • Package version(s): 3.28.1
  • Operating System: Mac OS - latest
  • Browser name and version: chrome Version 83.0.4103.106 (Build officiel) (64 bits)

Steps to reproduce

  1. Define a Select component with a custom item list render and item render
  2. Add itemPredicate function
  3. select an item
  4. Open the Select back ( active item isn't item selected )

Actual behavior

I don't know why but onActiveItemChange is fired twice when a itemPredicate is defined. First you get the selected item and just after onActiveItemChange is fired with the first item in the list with no reason.

Expected behavior

ActiveItem is the selected item when you open the list after a select.

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
ReactBlueprint Select component
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate the onActiveItemChange callback in the Select component, specifically how itemPredicate affects active item state. Look at the source code in packages/core/src/components/select/select.tsx and related handler functions. Check if active item reset occurs when predicate filters the list, causing the first item to become active incorrectly.