palantir/blueprint

Cannot render Collapse inside table rows or cells

開放

#3,951 建立於 2020年2月2日

 (0 則留言) (3 個反應) (0 位負責人)TypeScript (2,167 個分叉)batch import
P2Package: coreType: bughelp wanted

倉庫指標

星標
 (20,263 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

Environment

  • Package version(s): 3.18
  • Browser and OS versions: Chrome 79.0.3945.117; Windows 10 Home OS Build: 18362.592

If possible, link to a minimal repro (fork this code sandbox): https://codesandbox.io/s/blueprint-sandbox-kxl82

Steps to reproduce

  1. Make Collapse element visible by clicking plus button

Actual behavior

Collapse renders a tr root element, then wraps the contents in an invalid <div> tag, which causes the browser to wrap the div in a td element. Discussed here: https://github.com/palantir/blueprint/issues/3652

Expected behavior

Collapse renders one or more tr elements containing td children into the existing table

Possible solution

The root tag specified by the component prop is rendered and passed container style classes, etc., but then a div tag is hardcoded as the direct child. The div would need to be removed, since it is not a valid child of a tr or other table elements. Could the properties currently embedded in the div be passed directly to the children?

貢獻者指南