palantir/blueprint

Unable to select a single day when the intended day equals the start or the end of a previously selected date range

Open

#3,720 建立於 2019年9月2日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P3Package: datetimeType: enhancementhelp wanted

描述

Environment

  • Package version(s): 3.11.0
  • Browser and OS versions: Google Chrome 76 on macOS 10.14.5

Sandbox: https://codesandbox.io/s/blueprint-sandbox-wsj6f

Steps to reproduce

  1. Select a date range, e.g. from the 3rd of August to the 15th of August.
  2. Now you want to select the 3rd of August as a single-day range.
  3. When clicking on this day, you are unable to select it since it is already the start of the previously selected date range.
  4. The same applies if you want to use the last day of the previously selected date range, the 15th of August.

Actual behavior

When clicking the days in 3. and 4. the buttons are deselected.

Expected behavior

When clicking the days in 3. and 4. the buttons keep selected and can be used for a new single-day range.

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with ReactUnderstanding of date range picker UIBasic TypeScript
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine the DateRangePicker component in the Blueprint repository, particularly the selection logic that handles clicks on days that are boundaries of an existing range. The sandbox (https://codesandbox.io/s/blueprint sandbox wsj6f) demonstrates the bug. Look for code that updates the selected range on day click events, likely in packages/datetime/src/dateRangePicker. Check if there are existing tests and consider adding a condition to allow selecting a single day even if it matches a boundary of the previous range. The issue has one comment, which may contain additional context.