palantir/blueprint

Add a "onGrab" event to the Slider

Open

#3,575 建立於 2019年5月29日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: coreType: feature requesthelp wanted

描述

Environment

Package version: @blueprintjs/core 3.15.1 Browser: Chrome 74+

Feature request

Currently the slider supports an onChange and onRelease event - it would be useful to also have an onGrab (or similar) event which is invoked when the user grabs the slider handle without releasing it.

Examples

A scenario when this would be useful is when using the slider as a scrubber control for a video. If the value of the slider is updated due to the user grabbing the handle and sliding, we would want to:

  • Immediately reflect the new value in the slider so that it stays responsive; but
  • Debounce the updates that tell the video to load at the current time. Otherwise we end up loading/trying to show a lot of "intermediate" frames that just get dropped as the user slides the handle.

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactTypeScriptBlueprint Slider component
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
Investigate the Slider component implementation (likely in packages/core/src/components/slider) to understand how onChange and onRelease are currently handled. Identify where the handle grab event occurs (e.g., mousedown or touchstart). Add a new onGrab prop to the Slider interface and invoke it at the appropriate time. Ensure the new event is properly typed in TypeScript. Refer to existing event handlers for consistency.