palantir/blueprint

Wrong maxTime displayed in DateRangeInput with timePickerProps

Open

#3,509 建立於 2019年5月1日

在 GitHub 查看
 (2 留言) (3 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
Domain: APIP2Package: datetimeType: bughelp wanted

描述

Environment

  • Package version(s): @blueprintjs/core:3.15.1 @blueprintjs/datetime:3.9.0 react:16.8.6
  • Browser and OS versions: Google Chrome 74 Mozilla Firefox 66 Linux Mint 18.3

https://codesandbox.io/s/m7n7mvvoyy

Steps to reproduce

  1. In a DateRangeInput set the minDate and maxDate and use the same minDate and maxDate to supply minTime and maxTime (respectively) in said DateRangeInput's timePickerProps.
  2. Open the DateRangePicker by focusing in the input box.

Actual behavior

Notice that the times at the bottom of the DateRangePicker popover both contain the time taken from the minTime prop supplied. The time from the maxTime prop doesn't get applied.

Expected behavior

The time input on the left should contain the time extracted from the supplied minTime prop and the time input on the right should contain the time extracted from the supplied maxTime prop.

Possible solution

貢獻者指南

技術棧
reacttypescript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic knowledge of ReactUnderstanding of Blueprint's DateRangeInput component
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
The issue is in the DateRangeInput component where the maxTime from timePickerProps is not applied to the right (end) time picker. Investigate how timePickerProps are split and passed to the two underlying DatePicker components in the file `src/components/date time/dateRangeInput.tsx`. Look for where the time picker props are assigned to each date picker, and ensure that minTime and maxTime are correctly mapped to the start and end pickers respectively. Check the component's internal state and prop handling logic.