palantir/blueprint

Dev mode warning for Tooltip wrapping a disabled Button

Open

#3,494 建立於 2019年4月23日

在 GitHub 查看
 (0 留言) (2 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
Domain: APIP2Package: coreType: enhancementhelp wanted

描述

Even though it's well-documented, the issue comes up frequently: https://github.com/palantir/blueprint/issues/967#issuecomment-485615346

We should log a warning in development mode, suggesting use of an AnchorButton instead. Writing a lint rule seems like it would be harder than introspecting the React tree at runtime.

cc @thelastnode

貢獻者指南

技術棧
reacttypescript
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactBlueprint componentsTypeScript
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Implement a dev mode warning in the Tooltip component that checks if its children include a disabled Button. Inspect the Tooltip component source in the Blueprint repository (likely in packages/core/src/components/tooltip). Use React.Children or React.Children.forEach to iterate over children and check if any element is a Button with disabled prop. If so, log a warning suggesting AnchorButton. Look at existing dev warnings in Blueprint (e.g., using the debug package or process.env.NODE ENV) to maintain consistency.
Dev mode warning for Tooltip wrapping a disabled Button · palantir/blueprint#3494 | Good First Issue